Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo warnings #1766

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix cargo warnings #1766

merged 2 commits into from
Mar 19, 2024

Conversation

adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Mar 19, 2024

CI is currently broken logs here. Trying to fix.

OK I've fixed it. Process to fix was:

  1. Revert be3fed8 ("Add support for line, xLine, yLine, xLineTo, yLineTo (Add support for line, xLine, yLine, xLineTo, yLineTo #1754)")
  2. Restore that commit without any of its changes to Cargo.lock (it had, IMO, a lot of unnecessary changes)
  3. cargo update -p kittycad-execution-plan (redoing only the necessary changes)

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Mar 19, 2024 9:19pm

@adamchalmers adamchalmers enabled auto-merge (squash) March 19, 2024 21:11
@adamchalmers adamchalmers enabled auto-merge (squash) March 19, 2024 21:13
@adamchalmers adamchalmers merged commit e3e132c into main Mar 19, 2024
18 of 19 checks passed
@adamchalmers adamchalmers deleted the achalmers/fix-cargo branch March 19, 2024 21:19
@pierremtb pierremtb mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant